Re: [PATCH] n_gsm.c: add tx_lock in gsm_send

[Alan Cox]

On Thu, 20 Dec 2012 08:38:40 +0800
Xiao Jin <jin.xiao@xxxxxxxxx> wrote:

> From: xiaojin <jin.xiao@xxxxxxxxx>
> Date: Wed, 19 Dec 2012 11:53:43 +0800
> Subject: [PATCH] n_gsm.c: add tx_lock in gsm_send
> 
> All the call to gsm->output should be in the tx_lock,
> that could avoid potential race from MUX level. But
> we have no tx_lock in gsm_send.
> 
> This patch is to add tx_lock in gsm_send.

gsm->output calls the transmit method of the underlying tty driver. We
can't do that with interrupts off as some drivers expect to be able to
sleep in their output paths.

Alan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/