Antw: [PATCH 0/5] kfifo cleanup and log based kfifo API
From: Ulrich Windl
Date: Tue Jan 08 2013 - 10:03:09 EST
>>> Yuanhan Liu <yuanhan.liu@xxxxxxxxxxxxxxx> schrieb am 08.01.2013 um 15:57 in
Nachricht <1357657073-27352-1-git-send-email-yuanhan.liu@xxxxxxxxxxxxxxx>:
[...]
> My proposal is to replace kfifo_init with kfifo_alloc, where it
> allocate buffer and maintain fifo size inside kfifo. Then we can
> remove buggy kfifo_init.
[...]
Spontaneously I feel that emitting a critical message if the requested size is not a power of two would be a good idea, as well as (in that case) rounding up to the next power of two instead of rounding down seems not too stupid ;-)
Sorry, I'm not deeply into recent kernel development.
Regards,
Ulrich
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/