Re: your patch "x86, 8042: Enable A20 using KBC to fix S3resume on some MSI laptops"

[Jan Beulich]

>>> On 14.01.13 at 09:54, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
> On Monday 14 January 2013, Jan Beulich wrote:
>> >>> On 14.01.13 at 09:29, Ondrej Zary <linux@xxxxxxxxxxxxxxxxxxxx> wrote:
>> > On Monday 14 January 2013, Jan Beulich wrote:
>> >> Second, considering that enabling A20 (even if just in a fake way),
>> >> is a core system operation, I don't think it belongs into a driver
>> >> that is only optionally present in the kernel.
>> >
>> > The first version of this patch added A20 enabling to early init code.
>> > But that could be dangerous as it was run before any 8042 detection,
>> > possibly breaking systems without 8042. I haven't found a better place
>> > for this.
>>
>> I realize that the change would be more intrusive, but imo that's
>> not an excuse for not doing it properly.
> 
> What's "properly"? Doing extra 8042 detection somewhere else does not look 
> right.

Why?

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/