Re: USB device cannot be reconnected and khubd "blocked for more than120 seconds"

[Linus Torvalds]

On Tue, Jan 15, 2013 at 7:05 PM, Ming Lei <ming.lei@xxxxxxxxxxxxx> wrote:
>
> So looks only sd.c and floppy.c are to be synchronized suppose
> some sync interfaces are introduced, doesn't it?

What about ata_host_register() (usually called through ata_host_activate())?

I don't understand why you continue to push for something fragile
where you have to get things right in the driver, when it clearly is
very fragile indeed, as now shown *twice* by how you seem to have
missed some potential case.

This is *exactly* why I NAK'ed the patch, and said it has to be
handled automatically (or at least default to the safe model, not the
unsafe one).

We do have the automatic patch now. Admittedly it's not wonderful, and
I agreed when Tejun called it slightly ugly, but at least it does
these things automatically without humans having to go through these
cases one by one and having to get them right. So please just stop
pushing this "manual marking" thing. It's fundamentally flawed and
broken.

             Linus
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/