Re: [PATCH v4 2/4] ARM: Exynos5250: Enabling ohci-exynos driver

[Tomasz Figa]

Hi Vivek,

On Tuesday 15 of January 2013 19:08:30 Vivek Gautam wrote:
> Adding OHCI device tree node for Exynos5250 along with
> the device base address.
> 
> Signed-off-by: Vivek Gautam <gautam.vivek@xxxxxxxxxxx>
> Acked-by: Jingoo Han <jg1.han@xxxxxxxxxxx>
> Acked-by: Grant Likely <grant.likely@xxxxxxxxxxxx>
> ---
>  .../devicetree/bindings/usb/exynos-usb.txt         |   15
> +++++++++++++++ arch/arm/boot/dts/exynos5250.dtsi                  |   
> 6 ++++++ 2 files changed, 21 insertions(+), 0 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> b/Documentation/devicetree/bindings/usb/exynos-usb.txt index
> e8bbb47..f66fcdd 100644
> --- a/Documentation/devicetree/bindings/usb/exynos-usb.txt
> +++ b/Documentation/devicetree/bindings/usb/exynos-usb.txt
> @@ -23,3 +23,18 @@ Example:
>  		interrupts = <0 71 0>;
>  		samsung,vbus-gpio = <&gpx2 6 1 3 3>;
>  	};
> +
> +OHCI
> +Required properties:
> + - compatible: should be "samsung,exynos4210-ohci" for USB 2.0
> +   OHCI companion controller in host mode.
> + - reg: physical base address of the controller and length of memory
> mapped +   region.
> + - interrupts: interrupt number to the cpu.
> +
> +Example:
> +	usb@12120000 {
> +		compatible = "samsung,exynos4210-ohci";
> +		reg = <0x12120000 0x100>;
> +		interrupts = <0 71 0>;
> +	};
> diff --git a/arch/arm/boot/dts/exynos5250.dtsi
> b/arch/arm/boot/dts/exynos5250.dtsi index 2cbe53e..ebb0907 100644
> --- a/arch/arm/boot/dts/exynos5250.dtsi
> +++ b/arch/arm/boot/dts/exynos5250.dtsi
> @@ -281,6 +281,12 @@
>  		interrupts = <0 71 0>;
>  	};
> 
> +	usb@12120000 {
> +		compatible = "samsung,exynos4210-ohci";
> +		reg = <0x12120000 0x100>;
> +		interrupts = <0 71 0>;

For Samsung platforms we decided per board enabling of nodes and so this 
node should also contain:

		status = "disabled";

while in dts file of board using ohci there would be an overriding entry:

	usb@12120000 {
		status = "okay";
	};

I know that Exynos5250 has not been yet converted into this convention, 
but using it when adding new devices will simplify the process.

Best regards,
Tomasz

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/