Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

[kishon]

Hi,

On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote:
> On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote:
> > This is in preparation for the changes in PHY library to support adding
> > and getting multiple PHYs of the same type. In the new design, the
> > binding information between the PHY and the USB controller should be
> > specified in the platform specific initialization code. So it's been
> > done for OMAP platforms here.
> >
> > Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
> > ---
> > This kind-of binding should be done in all the platforms (I've done only
> > for OMAP platform).
> >   arch/arm/mach-omap2/usb-musb.c |    7 ++++++-
> >   1 file changed, 6 insertions(+), 1 deletion(-)
> >
> > diff --git a/arch/arm/mach-omap2/usb-musb.c b/arch/arm/mach-omap2/usb-musb.c
> > index 9d27e3f..bbe2fa5 100644
> > --- a/arch/arm/mach-omap2/usb-musb.c
> > +++ b/arch/arm/mach-omap2/usb-musb.c
> > @@ -24,6 +24,7 @@
> >   #include <linux/dma-mapping.h>
> >   #include <linux/io.h>
> >   #include <linux/usb/musb.h>
> > +#include <linux/usb/phy.h>
> >
> >   #include "omap_device.h"
> >   #include "soc.h"
> > @@ -85,8 +86,12 @@ void __init usb_musb_init(struct omap_musb_board_data *musb_board_data)
> >   	musb_plat.mode = board_data->mode;
> >   	musb_plat.extvbus = board_data->extvbus;
> >
> > -	if (cpu_is_omap44xx())
> > +	if (cpu_is_omap44xx()) {
> >   		musb_plat.has_mailbox = true;
> > +		usb_bind_phy("musb-hdrc.0.auto", 0, "omap-usb2.1.auto");
> > +	} else if (cpu_is_omap34xx()) {
> > +		usb_bind_phy("musb-hdrc.0.auto", 0, "twl4030_usb");
> > +	}
>
> Are you sure than these OMAP platforms cannot be wired in any other way
> to the PHY?
>
> If they can be then this association must come from the board files or
> device tree.

I had given some thought about that and since all the existing OMAP 
platforms had it this way, I added it here.
You having pointed that out, I'll move these to board files.

Thanks
Kishon
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/