Re: [PATCH 00/10] TTY: switch flipping functions to tty_port

From: Steven Rostedt
Date: Fri Jan 18 2013 - 23:52:39 EST


On Wed, 2013-01-16 at 16:42 +0000, Alan Cox wrote:
> On Wed, 16 Jan 2013 16:59:58 +0100

> > OMG. It contains a true copy of serial_core!
>
> And it seems to just be another 165x0 driver anyway In fact it looks
> like the right thing to do is to take it out and shoot it. We've got a
> 16x50 driver already.
>
> There are a few bits of gunk in there to set custom board registers and
> to figure out the configuration. See drivers/tty/serial/8250/8250_pci.c
> and it ought to be possible to just plug it in there. The 422 stuff
> might need a bit more tweaking.

I've totally failed trying to get it working with 8250. I'm going to
start from scratch and take bits and pieces from other drivers and put
together something (hopefully) a bit more sane.

It actually has a lot of duplicate code from omap-serial.c, or whatever
omap-serial copied from. I'm using that as a guide as well.

I'll post something in a few weeks (I'm basically doing this outside of
my regular choirs). It will still be crap, as I'm really a noob with the
serial tty code.

I've written serial drivers in the past, but just to get things to do
basic communication. Nothing with interacting with the tty layer. That's
new for me, and as a noob, I'm sure I'll produce something that will
surely make all of you go...

http://bit.ly/10hq0Kh

-- Steve


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/