Re: [patch] f2fs: use _safe() version of list_for_each
From: Jaegeuk Kim
Date: Mon Jan 21 2013 - 04:19:58 EST
2013-01-21 (ì), 00:32 -0800, Dmitry Torokhov:
> On Sun, Jan 20, 2013 at 06:02:58PM +0300, Dan Carpenter wrote:
> > This is calling list_del() inside a loop which is a problem when we try
> > move to the next item on the list. I've converted it to use the _safe
> > version. And also, as a cleanup, I've converted it to use
> > list_for_each_entry instead of list_for_each.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@xxxxxxxxxx>
> > ---
> > Static analysis stuff. Untested. Please review carefully.
>
> Makes sense to me.
>
> Reviewed-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
No doubt, applied.
Thanks,
--
Jaegeuk Kim
Samsung
Attachment:
signature.asc
Description: This is a digitally signed message part