Re: [PATCH] x86/apic: check FADT settings after enable x2apic

[Yinghai Lu]

On Tue, Jan 29, 2013 at 12:49 AM, Ingo Molnar <mingo@xxxxxxxxxx> wrote:
>
> * Wang, Song-Bo (Stoney) <song-bo.wang@xxxxxx> wrote:
>
>> [...] Due to this mode mismatch, with specific HW
>> configurations, there will be intermittent lost interrupts,
>> which could result in a hang or data loss.
>
> That's the key piece of information that was missing - which
> should be put into the changelog into a very prominent place.
>
>> Logically, there is a mismatch because the kernel missed
>> detection on HW configurations, and we should fix it, right?
>> Do we need more detailed information?
>
> No, the above sentence is more than enough and the fix looks
> nice. Note that this sentence is more useful to users than the
> rest of the changelog combined!

Please check attached.

Thanks

Yinghai

Attachment: wang_hp_x2apic.patch
Description: Binary data