[PATCH 2/7] cpufreq: Retrieve current frequency from scaling drivers with internal governors

From: dirk . brandewie
Date: Tue Feb 05 2013 - 13:24:32 EST


From: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>

Scaling drivers that implement the cpufreq_driver.setpolicy() versus
the cpufreq_driver.target() interface do not set policy->cur.

Normally policy->cur is set during the call to cpufreq_driver.target()
when the frequnecy request is made by the governor.

If the scaling driver implements cpufreq_driver.setpolicy() and
cpufreq_driver.get() interfaces use cpufreq_driver.get() to retrieve
the current frequency.

Signed-off-by: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx>
From: Dirk Brandewie <dirk.brandewie@xxxxxxxxx>
Date: 2013-02-04 18:44:40 -0800

cpufreq: balance out cpufreq_cpu_{get,put} for scaling drivers using setpolicy

There is an additional reference added to the driver in
cpufreq_add_dev() that is removed in__cpufreq_governor() if the
driver implements target(). Remove the last reference when the
driver implements setpolicy()

Signed-off-by: Dirk Brandewie <dirk.j.brandewie@xxxxxxxxx>
---
drivers/cpufreq/cpufreq.c | 7 +++++++
1 files changed, 7 insertions(+), 0 deletions(-)

diff --git a/drivers/cpufreq/cpufreq.c b/drivers/cpufreq/cpufreq.c
index 2817c3c..96bc302 100644
--- a/drivers/cpufreq/cpufreq.c
+++ b/drivers/cpufreq/cpufreq.c
@@ -1181,6 +1181,13 @@ unsigned int cpufreq_quick_get(unsigned int cpu)
struct cpufreq_policy *policy = cpufreq_cpu_get(cpu);
unsigned int ret_freq = 0;

+ if (cpufreq_driver && cpufreq_driver->setpolicy &&
+ cpufreq_driver->get) {
+ ret_freq = cpufreq_driver->get(cpu);
+ cpufreq_cpu_put(policy);
+ return ret_freq;
+ }
+
if (policy) {
ret_freq = policy->cur;
cpufreq_cpu_put(policy);
--
1.7.7.6

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/