Re: [PATCH 1/4] ARM: tegra: Unify tegra{20,30,114}_init_early()
From: Hiroshi Doyu
Date: Sun Feb 10 2013 - 23:19:03 EST
Hi Marc,
Marc Dietrich <marvin24@xxxxxx> wrote @ Sun, 10 Feb 2013 22:16:14 +0100:
> ah, ok - I just skipped the "also" in your sentence above. But still, the
> #ifdefs look strange to me and save only a few byte of code. Just me few
> cents.
What about the following as Arnd suggested[1]?
void __init tegra_hotplug_init(void)
{
if (!IS_ENABLED(CONFIG_HOTPLUG_CPU))
return;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_2x_SOC)) && tegra_chip_id == TEGRA20)
tegra_hotplug_shutdown = tegra20_hotplug_shutdown;
if (IS_ENABLED(CONFIG_ARCH_TEGRA_3x_SOC)) && tegra_chip_id == TEGRA30)
tegra_hotplug_shutdown = tegra30_hotplug_shutdown;
}
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2013-February/148632.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/