On 02/13/2013 12:02 AM, Laxman Dewangan wrote:On Tuesday 12 February 2013 11:16 PM, Stephen Warren wrote:I tested on Cardhu/Tegra30 (I'd previously only tested onOn 02/12/2013 08:17 AM, Laxman Dewangan wrote:I tested this in next-20130212 where "clock-frequency" is there inInitialise the parent of UARTs to PLLP and disabling clock byThis patch wasn't tested, was it? Without the patch I just sent titled
default.
"ARM: tegra: remove clock-frequency properties from serial nodes", the
UART clocks get turned off and the console breaks.
tegra30.dtsi file.
Harmony/Tegra20), and I see the exact same problem; the clock core turns
off the UART clock and the system hangs.
Are you sure you don't have any other local patches that somehow keep
the UART clock on (e.g. disabling clk_disable_unused, calling clk_get()
on the UART clock somewhere else, have the Tegra HS UART driver enabled
on the console port for testing which perhaps does an unconditional
clk_get). Are you sure you're testing with U-Boot rather than our binary
bootloader; who knows what kind of voodoo that does to clocks.
Note: I tested: a merge of arm-soc/for-next and Tegra's for-next branch,
with my patch to remove the clock-frequency properties reverted, plus a
fix for the boot crash ("clockevents: fix generic broadcast for
FEAT_C3STOP").
If you remove this from dts file at all then it will not work as thereThat returns 0 if the property is present (so doesn't get/enable the
is no execution path to call the clk_prepare_enable().
of_serial.c file:
if (of_property_read_u32(np, "clock-frequency", &clk)) {
clock), and an error code if the property is missing (so does get/enable
the clock).