Re: [PATCH] sound: usb/quirks, fix out-of-bounds access

[Takashi Iwai]

At Sun, 17 Feb 2013 14:33:04 +0100,
Jiri Slaby wrote:
> 
> bootresponse in snd_usb_mbox2_boot_quirk is only 12 (decimal) u8's
> long, but i9s passed to snd_usb_ctl_msg as it would be 0x12 (hexa)
> long. Fix that by having proper size of the array, i.e. 0x12.
> 
> Signed-off-by: Jiri Slaby <jslaby@xxxxxxx>
> Cc: Damien Zammit <damien@xxxxxxxxxxxx>
> Cc: Takashi Iwai <tiwai@xxxxxxx>

A good catch.  Applied now.  Thanks!


Takashi

> ---
>  sound/usb/quirks.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/sound/usb/quirks.c b/sound/usb/quirks.c
> index 2c97185..0115289 100644
> --- a/sound/usb/quirks.c
> +++ b/sound/usb/quirks.c
> @@ -533,7 +533,7 @@ static int snd_usb_mbox2_boot_quirk(struct usb_device *dev)
>  {
>  	struct usb_host_config *config = dev->actconfig;
>  	int err;
> -	u8 bootresponse[12];
> +	u8 bootresponse[0x12];
>  	int fwsize;
>  	int count;
>  
> -- 
> 1.8.1.2
> 
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/