Re: [PATCH v6 4/7] fat: restructure export_operations
From: Namjae Jeon
Date: Mon Feb 18 2013 - 09:05:39 EST
2013/2/18 OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>:
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx> writes:
>
>>> + if (parent && (len < FAT_FID_SIZE_WITH_PARENT)) {
>>> + *lenp = FAT_FID_SIZE_WITH_PARENT;
>>> + return 255;
>>> + } else if (len < FAT_FID_SIZE_WITHOUT_PARENT) {
>>> + *lenp = FAT_FID_SIZE_WITHOUT_PARENT;
>>> + return 255;
>
> We would be better to use FILEID_INVALID on all places, instead of 255.
Yes, right. I will fix it.
Thanks!
> --
> OGAWA Hirofumi <hirofumi@xxxxxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/