Re: [PATCH] backlight: adp8860/adp8870: Fix resume

[Michael Hennerich]

On 02/19/2013 02:02 PM, Lars-Peter Clausen wrote:
> Clearing the NSTBY bit in the control register also automatically clears the
> BLEN bit. So we need to make sure to set it again during resume, otherwise the
> backlight will stay off.
>
> Cc: stable@xxxxxxxxxxxxxxx
> Signed-off-by: Lars-Peter Clausen <lars@xxxxxxxxxx>
Acked-by: Michael Hennerich <michael.hennerich@xxxxxxxxxx>
> ---
>   drivers/video/backlight/adp8860_bl.c | 2 +-
>   drivers/video/backlight/adp8870_bl.c | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/video/backlight/adp8860_bl.c b/drivers/video/backlight/adp8860_bl.c
> index 6bb72c0..a77c9ca 100644
> --- a/drivers/video/backlight/adp8860_bl.c
> +++ b/drivers/video/backlight/adp8860_bl.c
> @@ -783,7 +783,7 @@ static int adp8860_i2c_suspend(struct i2c_client *client, pm_message_t message)
>   
>   static int adp8860_i2c_resume(struct i2c_client *client)
>   {
> -	adp8860_set_bits(client, ADP8860_MDCR, NSTBY);
> +	adp8860_set_bits(client, ADP8860_MDCR, NSTBY | BLEN);
>   
>   	return 0;
>   }
> diff --git a/drivers/video/backlight/adp8870_bl.c b/drivers/video/backlight/adp8870_bl.c
> index 63c882b..712c25a 100644
> --- a/drivers/video/backlight/adp8870_bl.c
> +++ b/drivers/video/backlight/adp8870_bl.c
> @@ -957,7 +957,7 @@ static int adp8870_i2c_suspend(struct i2c_client *client, pm_message_t message)
>   
>   static int adp8870_i2c_resume(struct i2c_client *client)
>   {
> -	adp8870_set_bits(client, ADP8870_MDCR, NSTBY);
> +	adp8870_set_bits(client, ADP8870_MDCR, NSTBY | BLEN);
>   
>   	return 0;
>   }


--
Greetings,
Michael

--
Analog Devices GmbH      Wilhelm-Wagenfeld-Str. 6      80807 Muenchen
Sitz der Gesellschaft: Muenchen; Registergericht: Muenchen HRB 40368;
Geschaeftsfuehrer:Dr.Carsten Suckrow, Thomas Wessel, William A. Martin,
Margaret Seif


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/