Re: [patch 1/2] kcmp: Make it to depend on CONFIG_KCMP
From: H. Peter Anvin
Date: Tue Feb 19 2013 - 16:51:21 EST
On 02/19/2013 01:42 PM, Andrew Morton wrote:
Index: linux-2.6.git/kernel/Makefile
===================================================================
--- linux-2.6.git.orig/kernel/Makefile
+++ linux-2.6.git/kernel/Makefile
@@ -25,9 +25,7 @@ endif
obj-y += sched/
obj-y += power/
-ifeq ($(CONFIG_CHECKPOINT_RESTORE),y)
-obj-$(CONFIG_X86) += kcmp.o
-endif
+obj-$(CONFIG_KCMP) += kcmp.o
obj-$(CONFIG_FREEZER) += freezer.o
obj-$(CONFIG_PROFILING) += profile.o
obj-$(CONFIG_STACKTRACE) += stacktrace.o
This permits people to select kcmp with CONFIG_CHECKPOINT_RESTORE=n.
Is there any point in doing that?
What would be wrong with just doing
obj-$(CONFIG_CHECKPOINT_RESTORE) += kcmp.o
The real question is if there are any potential use cases of kcmp()
outside checkpoint/restore. It is actually a very general facility.
-hpa
--
H. Peter Anvin, Intel Open Source Technology Center
I work for Intel. I don't speak on their behalf.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/