Re: [PATCH] pch_dma: Use GFP_ATOMIC because called from interruptcontext

[Vinod Koul]

On Wed, Feb 20, 2013 at 11:26:54AM +0900, Tomoya MORINAGA wrote:
> Hi
> 
> Could you review this patch ?
> 8 days have passed...
Sorry looks like I missed it. I have queued it up and will apply after -rc1

--
~Vinod
> 
> thanks,
> tomoya
> 
> On Tue, Feb 12, 2013 at 11:25 AM, Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx> wrote:
> > pdc_desc_get() is called from pd_prep_slave_sg, and the function is
> > called from interrupt context(e.g. Uart driver "pch_uart.c").
> > In fact, I saw kernel error message.
> > So, GFP_ATOMIC must be used not GFP_NOIO.
> >
> > Signed-off-by: Tomoya MORINAGA <tomoya.rohm@xxxxxxxxx>
> > ---
> >  drivers/dma/pch_dma.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/dma/pch_dma.c b/drivers/dma/pch_dma.c
> > index 987ab5c..d5cbd44 100644
> > --- a/drivers/dma/pch_dma.c
> > +++ b/drivers/dma/pch_dma.c
> > @@ -476,7 +476,7 @@ static struct pch_dma_desc *pdc_desc_get(struct pch_dma_chan *pd_chan)
> >         dev_dbg(chan2dev(&pd_chan->chan), "scanned %d descriptors\n", i);
> >
> >         if (!ret) {
> > -               ret = pdc_alloc_desc(&pd_chan->chan, GFP_NOIO);
> > +               ret = pdc_alloc_desc(&pd_chan->chan, GFP_ATOMIC);
> >                 if (ret) {
> >                         spin_lock(&pd_chan->lock);
> >                         pd_chan->descs_allocated++;
> > --
> > 1.7.4.4
> 
> -- 
> ROHM Co., Ltd.
> tomoya
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/