Re: [PATCH] staging: android: ashmem: get_name, set_name not to hold ashmem_mutex

[Shankar Brahadeeswaran]

Hi Dan,
Thanks for the feedback. I have incorporated both your review comments
and have re-tested the patch.
I'll submit the patch for approval.

Warm Regards,
Shankar


On Tue, Feb 19, 2013 at 7:08 PM, Dan Carpenter <dan.carpenter@xxxxxxxxxx> wrote:
> Good job fixing the bug.  :)
>
> My one concern would be that in set_name() there is a race caused
> by dropping the lock.  It would be better to do that
> copy_from_user() first, before taking the lock.  I don't expect this
> to actually be a problem in real life.
>
> +       /*
> +        * Local variable to hold the name copied from user space
> +        * This variable is approx of size 270 bytes, not huge
> +        */
> +       char local_name[ASHMEM_NAME_LEN];
>
> These obvious comments are not needed.  We trust you do not overflow
> the stack.  ;)  Also it's checked automatically during build.
>
> Looks good generally.
>
> regards,
> dan carpenter
>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/