RE: [PATCH] freezer: configure user space process frozen along withkernel threads

[Li, Fei]

> -----Original Message-----
> From: Cyrill Gorcunov [mailto:gorcunov@xxxxxxxxx] On Behalf Of Cyrill
> Gorcunov
> Sent: Wednesday, February 20, 2013 5:05 PM
> To: Li, Fei
> Cc: pavel@xxxxxx; rjw@xxxxxxx; Brown, Len; mingo@xxxxxxxxxx;
> peterz@xxxxxxxxxxxxx; akpm@xxxxxxxxxxxxxxxxxxxx; viro@xxxxxxxxxxxxxxxxxx;
> ebiederm@xxxxxxxxxxxx; rientjes@xxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx;
> linux-pm@xxxxxxxxxxxxxxx; Liu, Chuansheng; Wang, Biao
> Subject: Re: [PATCH] freezer: configure user space process frozen along with
> kernel threads
> 
> On Wed, Feb 20, 2013 at 10:15:25AM +0800, Li Fei wrote:
> >
> > +#ifdef CONFIG_FREEZER
> > +
> > +static ssize_t freeze_late_read(struct file *file, char __user *buf,
> > +					size_t count, loff_t *ppos)
> > +{
> > +	struct task_struct *task = get_proc_task(file->f_path.dentry->d_inode);
> > +	char buffer[PROC_NUMBUF];
> > +	int freeze_late;
> > +	size_t len;
> > +	if (!task)
> > +		return -ESRCH;
> > +	freeze_late = (task->flags & PF_FREEZER_LATE) ? 1 : 0;
> > +	len = snprintf(buffer, sizeof(buffer), "%d\n", freeze_late);
> > +	return simple_read_from_buffer(buf, count, ppos, buffer, len);
> > +}
> 
> Don't you need put_task_struct() once you grabbed it?

Thanks for your reminder. I'll update it in later version.

Best Regards,
Li Fei
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/