Re: [PATCH V4] ARM: dts: add minimal DT support for DevKit8000

[Manish Badarkhe]

Hi Anil

On Wed, Feb 20, 2013 at 7:14 PM, Anil Kumar <anilk4.v@xxxxxxxxx> wrote:
> DevKit8000 is a beagle board clone from Timll, sold by
> armkits.com. The DevKit8000 has RS232 serial port, LCD, DVI-D,
> S-Video, Ethernet, SD/MMC, keyboard, camera, SPI, I2C, USB and
> JTAG interface.
>
> This patch adds the basic DT support for devkit8000. At this time, Information
> of twl4030 (PMIC), MMC1, I2C1 and leds are added.
>
> Signed-off-by: Anil Kumar <anilk4.v@xxxxxxxxx>
> Tested-by: Thomas Weber <thomas@xxxxxxxxxxx>
> ---
>  -This patch is based on top of kernel 3.8-rc5.
>
>  -Tested on Devkit8000.
>
> For V4:
>  -Tiny nitpick.
>
> For V3:
>  - Remove pin mux as done at device boot time by default.
>
> For V2:
>  - Change model name as "TimLL OMAP3 Devkit8000"
>  - Change compatible as "timll,omap3-devkit8000"
>  - Doing i2c1 pinmux default with pinctrl-single driver instead of i2c1
>    driver probe time.
>
> :100644 100644 5ebb44f... 22ebc76... M  arch/arm/boot/dts/Makefile
> :000000 100644 0000000... 2e1463a... A  arch/arm/boot/dts/omap3-devkit8000.dts
> :100644 100644 53cb380b.. ccecb76... M  arch/arm/mach-omap2/board-generic.c
>  arch/arm/boot/dts/Makefile             |    1 +
>  arch/arm/boot/dts/omap3-devkit8000.dts |  102 ++++++++++++++++++++++++++++++++
>  arch/arm/mach-omap2/board-generic.c    |    1 +
>  3 files changed, 104 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/Makefile b/arch/arm/boot/dts/Makefile
> index 5ebb44f..22ebc76 100644
> --- a/arch/arm/boot/dts/Makefile
> +++ b/arch/arm/boot/dts/Makefile
> @@ -102,6 +102,7 @@ dtb-$(CONFIG_ARCH_MXS) += imx23-evk.dtb \
>         imx28-tx28.dtb
>  dtb-$(CONFIG_ARCH_OMAP2PLUS) += omap2420-h4.dtb \
>         omap3-beagle.dtb \
> +       omap3-devkit8000.dtb \
>         omap3-beagle-xm.dtb \
>         omap3-evm.dtb \
>         omap3-tobi.dtb \
> diff --git a/arch/arm/boot/dts/omap3-devkit8000.dts b/arch/arm/boot/dts/omap3-devkit8000.dts
> new file mode 100644
> index 0000000..2e1463a
> --- /dev/null
> +++ b/arch/arm/boot/dts/omap3-devkit8000.dts
> @@ -0,0 +1,102 @@
> +/*
> + * Author: Anil Kumar <anilk4.v@xxxxxxxxx>
> + *
> + * This program is free software; you can redistribute it and/or modify
> + * it under the terms of the GNU General Public License version 2 as
> + * published by the Free Software Foundation.
> + */
> +/dts-v1/;
> +
> +/include/ "omap3.dtsi"
> +/ {
> +       model = "TimLL OMAP3 Devkit8000";
> +       compatible = "timll,omap3-devkit8000", "ti,omap3";
> +
> +       memory {
> +               device_type = "memory";
> +               reg = <0x80000000 0x10000000>;  /* 256 MB */
> +       };
> +
> +       leds {
> +               compatible = "gpio-leds";
> +
> +               heartbeat {
> +                       label = "devkit8000::led1";
> +                       gpios = <&gpio6 26 0>;  /* 186 -> LED1 */
> +                       default-state = "on";
> +                       linux,default-trigger = "heartbeat";
> +               };
> +
> +               mmc {
> +                       label = "devkit8000::led2";
> +                       gpios = <&gpio6 3 0>;   /* 163 -> LED2 */
> +                       default-state = "on";
> +                       linux,default-trigger = "none";
> +               };
> +
> +               usr {
> +                       label = "devkit8000::led3";
> +                       gpios = <&gpio6 4 0>;   /* 164 -> LED3 */
> +                       default-state = "on";
> +                       linux,default-trigger = "usr";
> +                };
> +       };
> +};
> +
> +&i2c1 {
> +       clock-frequency = <2600000>;
> +
> +       twl: twl@48 {
> +               reg = <0x48>;
> +               interrupts = <7>;       /* SYS_NIRQ cascaded to intc */
> +               interrupt-parent = <&intc>;
> +       };
> +};
> +
> +&i2c2 {
> +       status = "disabled";
> +};
> +
> +&i2c3 {
> +       status = "disabled";
> +};
> +
> +/include/ "twl4030.dtsi"
> +
> +&mmc1 {
> +       vmmc-supply = <&vmmc1>;
> +       vmmc_aux-supply = <&vsim>;
> +       bus-width = <8>;
> +};
> +
> +&mmc2 {
> +       status = "disabled";
> +};
> +
> +&mmc3 {
> +       status = "disabled";
> +};
> +
> +&wdt2 {
> +       status = "disabled";
> +};
> +
> +&mcbsp1 {
> +       status = "disabled";
> +};
> +
> +&mcbsp2 {
> +       status = "disabled";
> +};
> +
> +&mcbsp3 {
> +       status = "disabled";
> +};
> +
> +&mcbsp4 {
> +       status = "disabled";
> +};
> +
> +&mcbsp5 {
> +       status = "disabled";
> +};
> diff --git a/arch/arm/mach-omap2/board-generic.c b/arch/arm/mach-omap2/board-generic.c
> index 53cb380..ccecb76 100644
> --- a/arch/arm/mach-omap2/board-generic.c
> +++ b/arch/arm/mach-omap2/board-generic.c
> @@ -110,6 +110,7 @@ MACHINE_END
>
>  static const char *omap3_gp_boards_compat[] __initdata = {
>         "ti,omap3-beagle",
> +       "timll,omap3-devkit8000",
>         NULL,
>  };
>

Looks good to me.
Reviewed-by: Manish Badarkhe <badarkhe.manish@xxxxxxxxx>

Thanks
Manish Badarkhe
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/