Re: [PATCH v5 6/6] Input: Add ChromeOS EC keyboard driver

[Dmitry Torokhov]

On Wed, Feb 20, 2013 at 09:24:39AM -0800, Simon Glass wrote:
> +
> +			code = keycodes[pos];
> +			new_state = kb_state[col] & (1 << row);
> +			if (!!new_state != test_bit(code, idev->key)) {
> +				dev_dbg(ckdev->dev,
> +					"changed: [r%d c%d]: byte %02x\n",
> +					row, col, new_state);
> +
> +			input_report_key(idev, code, new_state);

Incorrect indentation.


> +			}

...

> +static int cros_ec_keyb_probe(struct platform_device *pdev)
> +{
> +	struct cros_ec_device *ec = dev_get_drvdata(pdev->dev.parent);
> +	struct device *dev = ec->dev;
> +	struct cros_ec_keyb *ckdev = NULL;
> +	struct input_dev *idev = NULL;

Why are we assigning these to NULL?

Otherwise

Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/