Re: [PATCH linux-next] DM RAID: validate_raid_redundancy: Silenceuninitialized variable warning

[Paul Menzel]

Dear Tim,


thanks for the patch.


Am Mittwoch, den 20.02.2013, 13:31 -0700 schrieb Tim Gardner:

Noting the `gcc` version and build environment is never wrong. ;-)

> drivers/md/dm-raid.c: In function 'raid_ctr':
> drivers/md/dm-raid.c:453:53: warning: 'rebuilds_per_group' may be used uninitialized in this function [-Wuninitialized]
> drivers/md/dm-raid.c:383:11: note: 'rebuilds_per_group' was declared here
> 
> It appears unlikely that rebuilds_per_group could be used before set,

Why? Otherwise the compiler would not complain, right?

> but set it to 0 anyways just to shutup GCC.

Unfortunately I do not know what linux-next version you tested, so the
line numbers are off in.

        $ git describe
        v3.7.5-4-g9c2ab66

> Cc: Alasdair Kergon <agk@xxxxxxxxxx>
> Cc: dm-devel@xxxxxxxxxx
> Cc: Neil Brown <neilb@xxxxxxx>
> Cc: linux-raid@xxxxxxxxxxxxxxx
> Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
> ---
>  drivers/md/dm-raid.c |    2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/md/dm-raid.c b/drivers/md/dm-raid.c
> index 9d6bf19..8005caf 100644
> --- a/drivers/md/dm-raid.c
> +++ b/drivers/md/dm-raid.c
> @@ -380,7 +380,7 @@ static int validate_region_size(struct raid_set *rs, unsigned long region_size)
>  static int validate_raid_redundancy(struct raid_set *rs)
>  {
>  	unsigned i, rebuild_cnt = 0;
> -	unsigned rebuilds_per_group, copies, d;
> +	unsigned rebuilds_per_group = 0, copies, d;
>  	unsigned group_size, last_group_start;
>  
>  	for (i = 0; i < rs->md.raid_disks; i++)


Thanks,

Paul

Attachment: signature.asc
Description: This is a digitally signed message part