Re: [BUG bisected]: apei_hest_parse explosion
From: Thomas Gleixner
Date: Fri Feb 22 2013 - 03:22:23 EST
On Fri, 22 Feb 2013, Rafael J. Wysocki wrote:
> On Friday, February 22, 2013 02:40:58 AM Rafael J. Wysocki wrote:
> > It looks like the hest_tab memory mapping is unmapped between acpi_hest_init()
> > and aer_acpi_firmware_first(), but I have no idea what may be responsible for
> > that.
> >
> > And the only relevant difference between now and before the commit above seems
> > to be the change of the acpi_hest_init() ordering (which now is called earlier).
>
> We actually don't really need to do that thing so early, I think. It looks like
> we only need to make it available early enough for the AER driver to be able to
> use it, so I wonder if moving the acpi_hest_init() to a separate
> subsys_initcall() will work around the problem. That is, something like the
> patch below.
Yes, that makes the machine boot.
> But even if this helps, I will be wanting to understand what's up here.
It's very simple. I have "acpi=off" on the command line. With that
acpi_hest_init is never called, so hest_disable is not set .....
Brilliant stuff that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/