Re: [PATCH v4] mfd: syscon: Add non-DT support
From: Thierry Reding
Date: Fri Feb 22 2013 - 03:52:26 EST
On Fri, Feb 22, 2013 at 04:29:55PM +0800, Dong Aisheng wrote:
> On Fri, Feb 22, 2013 at 08:27:19AM +0100, Thierry Reding wrote:
> ...
> > > > > Otherwise, i'm also ok with this patch.
> > > > > Acked-by: Dong Aisheng <dong.aisheng@xxxxxxxxxx>
> > > > >
> > > > > BTW, i did not see Samuel's tree having this new API.
> > > > > So, who will pick this patch?
> > > >
> > > > I have same question.
> > >
> > > I CCed Thierry and Greg who may know it.
> >
> > Yes, devm_ioremap_resource() never returns NULL. You always need to
> > check the returned pointer with IS_ERR(). The value that you return
> > should be extracted from the pointer with PTR_ERR().
>
> Thanks Thierry.
> Since Samuel's mdf tree does not have your patch introducing
> the new API of devm_ioremap_resource,
> do you know which tree this patch can go through, Greg's driver core tree?
I don't think it matters much at this point because Linus merged the
driver core tree yesterday, so anything that gets applied now should
automatically have the new API available.
Thierry
Attachment:
pgp00000.pgp
Description: PGP signature