Re: [PATCH] PM / devfreq: fix missing unlock on error in exynos4_busfreq_pm_notifier_event()
From: Rafael J. Wysocki
Date: Fri Feb 22 2013 - 07:35:19 EST
On Friday, February 22, 2013 06:33:58 AM MyungJoo Ham wrote:
> > On 12:33-20130222, Wei Yongjun wrote:
> > > From: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> > >
> > > Add the missing unlock before return from function
> > > exynos4_busfreq_pm_notifier_event() in the error
> > > handling case.
> > >
> > > This issue introduced by commit 8fa938
> > > (PM / devfreq: exynos4_bus: honor RCU lock usage)
> > >
> > > Signed-off-by: Wei Yongjun <yongjun_wei@xxxxxxxxxxxxxxxxx>
> > Arrgh.. Thanks for catching this :( My bad.
> >
> > Fix looks good to me. upto MyungJoo.
>
> Applied to devfreq repository.
> I'll send pull request to Rafael soon along with other patches.
>
> >
> > MyungJoo, Rafael,
> > btw, adding linux-pm@xxxxxxxxxxxxxxx to MAINTAINERS for devfreq might
> > be a nice idea to have right audience.
>
> It appears that replacing the current mailing list address with linux-pm is
> appropriate. If no one objects, I'll post the suggestion later.
Sure, please do.
Thanks,
Rafael
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/