Re: [PATCH] backlight: ams369fg06: convert ams369fg06 to dev_pm_ops

[Andrew Morton]

On Fri, 22 Feb 2013 19:42:59 +0900
Jingoo Han <jg1.han@xxxxxxxxxxx> wrote:

> Instead of using legacy suspend/resume methods, using newer dev_pm_ops
> structure allows better control over power management.
> 
> ...
>
> @@ -571,12 +571,13 @@ static struct spi_driver ams369fg06_driver = {
>  	.driver = {
>  		.name	= "ams369fg06",
>  		.owner	= THIS_MODULE,
> +#ifdef CONFIG_PM
> +		.pm	= &ams369fg06_pm_ops,
> +#endif
>  	},
>  	.probe		= ams369fg06_probe,
>  	.remove		= ams369fg06_remove,
>  	.shutdown	= ams369fg06_shutdown,

Are the ifdefs needed?  There's various macro trickery in pm.h to clean
this up - the rtc drivers use it.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/