Re: [PATCH] i2c: s3c2410: check for NULL pinctrl handle
From: Linus Walleij
Date: Sun Feb 24 2013 - 17:39:52 EST
On Sun, Feb 24, 2013 at 6:00 PM, Tomasz Figa <tomasz.figa@xxxxxxxxx> wrote:
>> > Note that we are talking here about a temporary solution. The legacy
>> > DT- based pin configuration will go away after all the DT-enabled
>> > platforms using this driver get migrated to pin control and so will
>> > the need to check if pin control is available.
>> So use AUXDATA, and you get a pdata for that driver?
> Hmm, and then have some platform data passed statically and some parsed
> from device tree?
This is done by several in-tree drivers today. It is even necessary for things
like machine-specific callbacks.
> Not even saying that we are going towards getting rid of
> auxdata, not adding further dependencies for it.
The other option is to do the non-temporary solution you are
referring to below...
> Sorry, but this sounds more broken to me than checking the return value of
> devm_pinctrl_get_select_default for NULL in the driver.
Both are bad solution, auxdata is less bad than trying to check
struct pinctrl * handles for non-NULL, which has *never* been a
good thing to do and should never have been merged in the first
(Maybe I ACKed that, then I was doing something stupid.)
> Still, all the platforms relying on the legacy DT GPIO support should have
> been already migrated to pin control, so ideally instead of "fixing" the
> drivers to continue supporting the deprecated method, such platforms
> should be fixed.
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/