Re: [PATCH v5 5/6] Input: matrix-keymap: Add function to read the newDT binding

From: Simon Glass
Date: Mon Feb 25 2013 - 16:53:54 EST


Hi Dmitry,

On Wed, Feb 20, 2013 at 10:18 AM, Dmitry Torokhov
<dmitry.torokhov@xxxxxxxxx> wrote:
> On Wed, Feb 20, 2013 at 09:24:38AM -0800, Simon Glass wrote:
>> We now have a binding which adds two parameters to the matrix keypad DT
>> node. This is separate from the GPIO-driven matrix keypad binding, and
>> unfortunately incompatible, since that uses row-gpios/col-gpios for the
>> row and column counts.
>>
>> So the easiest option here is to provide a function for non-GPIO drivers
>> to use to decode the binding.
>>
>> Note: We could in fact create an entirely separate structure to hold
>> these two fields, but it does not seem worth it, yet. If we have more
>> parameters then we can add this, and then refactor each driver to hold
>> such a structure.
>>
>> Signed-off-by: Simon Glass <sjg@xxxxxxxxxxxx>
>> Tested-by: Sourav Poddar <sourav.poddar@xxxxxx> (v2)
>
> Acked-by: Dmitry Torokhov <dmitry.torokhov@xxxxxxxxx>
>
> I suppose the EC driver will go through MFD tree, right?

Yes I expect so.

Regards,
Simon

>
> --
> Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/