Re: [PATCH] thinkpad_acpi: moved hotkey_thread_mutex lock afterset_freezable()

From: Andrew Morton
Date: Mon Feb 25 2013 - 18:54:50 EST


On Sun, 24 Feb 2013 13:22:02 +0400
Artem Savkov <artem.savkov@xxxxxxxxx> wrote:

> set_freezable() checks freezing during which no locks should be held.
> hotkey_thread_mutex lock should be moved closer to where it is actually needed.
>

Thanks.

When fixing a bug, we always like to see a full description of that bug
so we can better work out which kernel versions need the fix.

Did you actually hit a lockup because of this? Or was it just from
code inspection? Or ... ?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/