[Question]CLOCK_EVT_NOTIFY_BROADCAST_EXIT must be called withinterrupts disabled?

From: Liu, Chuansheng
Date: Tue Feb 26 2013 - 03:02:04 EST


Just found some comments as below:
In commit 0beefa208bb3a9e581a60125703
+ /*
+ * The switch back from broadcast mode needs to be
+ * called with interrupts disabled.
+ */
+ local_irq_disable();
+ clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
+ local_irq_enable();

But checked some place in kernel code, it likes below in intel_idle.c:

if (!(lapic_timer_reliable_states & (1 << (cstate))))
clockevents_notify(CLOCK_EVT_NOTIFY_BROADCAST_EXIT, &cpu);
Which enable the irq at first, then calling CLOCK_EVT_NOTIFY_BROADCAST_EXIT.

So not sure _BROAD_EXIT must be called with interrupts disabled? Thanks your comments in advance.

To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/