RE: [PATCH linux/linux-next] mpt2sas:_scsih_sas_broadcast_primitive_event: Quiet unused variable warning

From: Reddy, Sreekanth
Date: Tue Feb 26 2013 - 07:18:22 EST


Hi Tim,

Today I have sent the below titled patch to upstream which fix the "Unused variable 'event_data' warning".
The Patch title is
"[PATCH][SCSI] mpt2sas: fix for unused variable 'event_data' warning"

This patch will help you in fixing the "Unused variable 'event_data' warning".

Thanks,
Sreekanth

> -----Original Message-----
> From: linux-scsi-owner@xxxxxxxxxxxxxxx [mailto:linux-scsi-
> owner@xxxxxxxxxxxxxxx] On Behalf Of Tim Gardner
> Sent: Thursday, February 21, 2013 12:18 AM
> To: linux-kernel@xxxxxxxxxxxxxxx
> Cc: Tim Gardner; Nandigama, Nagalakshmi; Reddy, Sreekanth; Support;
> James E.J. Bottomley; DL-MPT Fusion Linux; linux-scsi@xxxxxxxxxxxxxxx
> Subject: [PATCH linux/linux-next] mpt2sas:
> _scsih_sas_broadcast_primitive_event: Quiet unused variable warning
>
> If CONFIG_SCSI_MPT2SAS_LOGGING is undefined, then these warnings are
> emitted:
>
> drivers/scsi/mpt2sas/mpt2sas_scsih.c: In function
> '_scsih_sas_broadcast_primitive_event':
> drivers/scsi/mpt2sas/mpt2sas_scsih.c:5810:40: warning: unused variable
> 'event_data' [-Wunused-variable]
>
> Add __maybe_unused to the definition of event_data.
>
> Cc: Nagalakshmi Nandigama <Nagalakshmi.Nandigama@xxxxxxx>
> Cc: Sreekanth Reddy <Sreekanth.Reddy@xxxxxxx>
> Cc: support@xxxxxxx
> Cc: "James E.J. Bottomley" <JBottomley@xxxxxxxxxxxxx>
> Cc: DL-MPTFusionLinux@xxxxxxx
> Cc: linux-scsi@xxxxxxxxxxxxxxx
> Signed-off-by: Tim Gardner <tim.gardner@xxxxxxxxxxxxx>
> ---
> drivers/scsi/mpt2sas/mpt2sas_scsih.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> index c6bdc92..416f907 100644
> --- a/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> +++ b/drivers/scsi/mpt2sas/mpt2sas_scsih.c
> @@ -5807,7 +5807,8 @@ _scsih_sas_broadcast_primitive_event(struct
> MPT2SAS_ADAPTER *ioc,
> u32 termination_count;
> u32 query_count;
> Mpi2SCSITaskManagementReply_t *mpi_reply;
> - Mpi2EventDataSasBroadcastPrimitive_t *event_data = fw_event-
> >event_data;
> + Mpi2EventDataSasBroadcastPrimitive_t *event_data
> __maybe_unused =
> + fw_event->event_data;
> u16 ioc_status;
> unsigned long flags;
> int r;
> --
> 1.7.9.5
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-scsi" in the
> body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at
> http://vger.kernel.org/majordomo-info.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/