Re: [PATCH] gpio: palmas: add in GPIO support for palmas charger

[Laxman Dewangan]

On Tuesday 26 February 2013 06:51 PM, Ian Lartey wrote:
> this patch depenfs on [PATCH] mfd: palmas: is_palmas_charger needed by multiple drivers
>
> Palmas charger has 16 GPIOs
> add palmas_gpio_[read|write|update] api to take account
> second bank of GPIOs
>
> Signed-off-by: Ian Lartey <ian@xxxxxxxxxxxxxxx>
> Signed-off-by: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
> ---

>   
> +	/* palmas charger has 16 gpios */
> +	if (is_palmas_charger(palmas->product_id))
> +		palmas_gpio->gpio_chip.ngpio = 16;
> +
what happen if it is not palma charger?
palmas_gpio->gpio_chip.ngpio = 8; is missing or it will overwrite somewhere.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/