Re: [PATCH] gpio: em: Add Device Tree support

[Dmitry Torokhov]

Hi Magnus,

On Tue, Feb 26, 2013 at 10:26:23PM +0900, Magnus Damm wrote:
> From: Magnus Damm <damm@xxxxxxxxxxxxx>
> 
> Update the Emma Mobile GPIO driver to add DT support.
> 

...

> @@ -366,15 +387,33 @@ static int em_gio_remove(struct platform
>  	return 0;
>  }
>  

#ifdef CONFIG_OF here? No need to have extra aliases in modules if OF
support is not enabled (or is entire ARM arch now enables device tree?).

> +static const struct of_device_id em_gio_dt_ids[] = {
> +	{ .compatible = "renesas,em-gio", },
> +	{},
> +};
> +MODULE_DEVICE_TABLE(of, em_gio_dt_ids);
> +
>  static struct platform_driver em_gio_device_driver = {
>  	.probe		= em_gio_probe,
>  	.remove		= em_gio_remove,
>  	.driver		= {
>  		.name	= "em_gio",
> +		.of_match_table = em_gio_dt_ids,
> +		.owner		= THIS_MODULE,
>  	}
>  };
>  

-- 
Dmitry
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/