Re: [PATCH] PM / OPP: improve introductory documentation
From: Nishanth Menon
Date: Tue Feb 26 2013 - 18:44:29 EST
On 15:39-20130226, Randy Dunlap wrote:
> On 02/26/13 15:10, Nishanth Menon wrote:
> > On 14:43-20130226, Randy Dunlap wrote:
> >> On 02/26/13 09:37, Nishanth Menon wrote:
> > [..]
> >>> 1. Introduction
> >>> ===============
> >>> +1.1 What is an Operating Performance Point (OPP)?
> >>> +
> >>> Complex SoCs of today consists of a multiple sub-modules working in conjunction.
> >>> In an operational system executing varied use cases, not all modules in the SoC
> >>> need to function at their highest performing frequency all the time. To
> >>> facilitate this, sub-modules in a SoC are grouped into domains, allowing some
> >>> domains to run at lower voltage and frequency while other domains are loaded
> >>> -more. The set of discrete tuples consisting of frequency and voltage pairs that
> >>> +more.
> >> huh???
> > I split the definition line to it's own paragraph below. But, I think
> > you intend to say we could improve better the remaining paragraph.
> > Could you elaborate your thoughts?
> "while other domains are loaded more." Some people probably understand
> that OK; I dunno. I would rather see it written out more verbosely, e.g.:
> "while other domains run at voltage/frequency pairs that are higher."
You are right, being verbose here makes sense. I will pick up your wording
here in v2. Thanks for reviewing and helping improve.
> but partly I was confused by the diff(1) lines. my bad :(
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/