Re: [PATCH 1/3] workqueue: define mod_scheduled_delayed_work[_on]()helpers

From: Tejun Heo
Date: Wed Feb 27 2013 - 10:29:59 EST


Hello, Viresh.

On Wed, Feb 27, 2013 at 08:44:52PM +0530, Viresh Kumar wrote:
> To keep things aligned probably i should replace schedule_work() with
> queue_work() and use system_wq there too..

Yeah, that probably is more preferable. There are codes like the
following in kernel and they always irk me.

if (custom_wq)
queue_work();
else
schedule_work();

It's just silly.

Thanks.

--
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/