Re: [PATCH] drivers/block/xen-blkback: preq.dev is used withoutinitialized

[Konrad Rzeszutek Wilk]

On Wed, Feb 27, 2013 at 10:45:35AM +0000, Jan Beulich wrote:
> >>> On 27.02.13 at 11:38, Chen Gang <gang.chen@xxxxxxxxxxx> wrote:
> > ä 2013å02æ27æ 17:57, Jan Beulich åé:
> >> You also could have mentioned that even before commit 
> >> 01c681d4c70d64cb72142a2823f27c4146a02e63 the value printed
> >> here was bogus, as it was the guest provided value from
> >> req->u.rw.handle rather than the actual device.
> > 
> >   pardon ?
> > 
> >   I guess what you said is :
> >     my patch seems ok, but the comments need improving.
> >     need add "additional info" in comments:
> >       "before commit 01c681d4c70d64cb72142a2823f27c4146a02e63
> >        the value printed here was bogus, as it was the guest
> >        provided value from req->u.rw.handle rather than the
> >        actual device".
> > 
> >   is it correct ?
> 
> Yes (and you might have missed the ACK that I had already sent
> before this reply - that mail got bounced for your address).

Yup. Chen, could you respin the patch with the extra comment and
the Ack from Jan please?

Thank you!
> 
> Jan
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/