Re: [PATCH 1/4] documentation: add palmas dts definition

From: Stephen Warren
Date: Wed Feb 27 2013 - 13:17:08 EST


On 02/20/2013 06:49 AM, J, KEERTHY wrote:
> Mark Brown wrote at Wednesday, February 20, 2013 4:57 PM:
>> On Wed, Feb 20, 2013 at 09:30:15AM +0530, J Keerthy wrote:
>>> From: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
>>>
>>> Add the DTS definition for the palmas device including the MFD children.
...
>>> diff --git a/Documentation/devicetree/bindings/mfd/palmas.txt b/Documentation/devicetree/bindings/mfd/palmas.txt
...
>>> +Texas Instruments Palmas family
>>> +
>>> +The Palmas familly are Integrated Power Management Chips.
>>> +These chips are connected to an i2c bus.
>>
>> I would expect this to enumerate the regulators that the user can
>> select but it doesn't appear to do that.
>
> Mark,
>
> Thanks for reviewing the patch.
>
> I went through the DT Documentation files in the regulator/ folder.
> So shall I add a list of regulators which are in the Palmas device
> Under a separate file under Documentation/devicetree/bindings/regulator ?
> Is that what you are looking for?

I believe what Mark wants is something like the following in this file
(take from Documentation/devicetree/bindings/regulator/tps6586x.txt):

> - regulators: A node that houses a sub-node for each regulator within the
> device. Each sub-node is identified using the node's name (or the deprecated
> regulator-compatible property if present), with valid values listed below.
> The content of each sub-node is defined by the standard binding for
> regulators; see regulator.txt.
> sys, sm[0-2], ldo[0-9] and ldo_rtc
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/