Re: [PATCH v2 2/3] freezer: do not send a fake signal to aPF_DUMPCORE thread

[Oleg Nesterov]

On 02/27, Oleg Nesterov wrote:
>
> On 02/26, Mandeep Singh Baines wrote:
> >
> > You'd rather have reliable suspend than coredumps that aren't
> > truncated so you need to set TIF_SIGPENDING to break waits in the
> > dump_write path.
>
> Oh, I agree. In this case the necessary changes look simple.

Really. What if we simply add

	if (signal_pending())
		// SIGKILL or freezing()
		return -EINTR;

into dump_write() and change 3/3 to use wait_event_interruptible?

At least for the start. This is at least consistent, we do not
prevent suspend but the coredumping can be truncated (with the
current code "truncated" can happen anyway).

Then we can try to make it freezable or simply forget about this
imho minor problem.

What do you think?

Oleg.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/