[PATCH] perf kvm: fix segfault by initializing file_name to NULL

From: David Ahern
Date: Wed Feb 27 2013 - 22:30:11 EST


Dongsoo reported that perf-kvm was segfaulting. The bug was introduced by
commit 3786063 which moved file_name from struct perf_kvm which was
initialized on the stack to an uninitialized stack variable. Fix by
initializing.

Needs to be applied to 3.7 and 3.8 as well.

Signed-off-by: David Ahern <dsahern@xxxxxxxxx>
Cc: Xiao Guangrong <xiaoguangrong@xxxxxxxxxxxxxxxxxx>
Cc: Dongsoo Nathaniel Kim <dongsoo.kim@xxxxxxxxx>
---
tools/perf/builtin-kvm.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/tools/perf/builtin-kvm.c b/tools/perf/builtin-kvm.c
index ca3f80e..e55701d 100644
--- a/tools/perf/builtin-kvm.c
+++ b/tools/perf/builtin-kvm.c
@@ -973,7 +973,7 @@ __cmd_buildid_list(const char *file_name, int argc, const char **argv)

int cmd_kvm(int argc, const char **argv, const char *prefix __maybe_unused)
{
- const char *file_name;
+ const char *file_name = NULL;

const struct option kvm_options[] = {
OPT_STRING('i', "input", &file_name, "file",
--
1.7.10.1

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/