Re: [PATCH] staging: si3226x: TDM: add issues to TODO file

From: Greg Kroah-Hartman
Date: Thu Feb 28 2013 - 11:57:30 EST


On Thu, Feb 28, 2013 at 04:30:52PM +0000, Kurachkin Michail wrote:
> Signed-off-by: Michail Kurachkin <michail.kurachkin@xxxxxxxxxxx>
> ---
> drivers/staging/si3226x/TODO | 20 +++++++++++++++++---
> drivers/staging/tdm/TODO | 19 +++++++++++++++++++
> 2 files changed, 36 insertions(+), 3 deletions(-)
> create mode 100644 drivers/staging/tdm/TODO
>
> diff --git a/drivers/staging/si3226x/TODO b/drivers/staging/si3226x/TODO
> index b2cb27e..e4c334a 100644
> --- a/drivers/staging/si3226x/TODO
> +++ b/drivers/staging/si3226x/TODO
> @@ -1,8 +1,22 @@
> +Mainteiners:
> +Michail Kurachkin <Michail.Kurachkin@xxxxxxxxxxx> <stelhs@xxxxxxxxx>
> +Ivan Kuten <ivan.kuten@xxxxxxxxxxx>
> +Promwad company <info@xxxxxxxxxxx>
> +
> +Reviwers:
> +Oliver Neukum <oneukum@xxxxxxx>
> +Ryan Mallon <rmallon@xxxxxxxxx>
> +Greg Kroah-Hartman <gregkh@xxxxxxxxxxxxxxxxxxx>

Why are you listing reviewers? We've never done that in a TODO file
before, please don't start.

And this should be two patches, one for each driver.

In fact, ideally it would be part of your original series. As I really
don't want to hand-edit the Subject: of those patches, can you just fix
this up properly and resend all of them, based on the comments I've
provided so far?

thanks,

greg k-h
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/