Re: [PATCH] Adds support for Open Firmware in MAX730x GPIO Driver

[Linus Walleij]

On Fri, Feb 22, 2013 at 10:26 AM, Christophe Leroy
<christophe.leroy@xxxxxx> wrote:

> This patch allows the use of the MAX730x Driver on systems using
> the Open Firmware platform format
>
> Signed-off-by: Patrick Vasseur <patrick.vasseur@xxxxxx>
> Signed-off-by: Christophe Leroy <christophe.leroy@xxxxxx>

(...)
>         /* bits_per_word cannot be configured in platform data */
> -       spi->bits_per_word = 16;
> +       if (spi->dev.platform_data)
> +               spi->bits_per_word = 16;

What about just fixing so you *can* specify that instead?
The comment looks more like a FIXME to me.

Yours,
Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/