Re: 8250.nr_uarts broken in 3.7

[Josh Boyer]

On Fri, Mar 08, 2013 at 11:58:39PM +0100, Jiri Slaby wrote:
> On 03/08/2013 11:49 PM, Josh Boyer wrote:
> > On Fri, Mar 08, 2013 at 11:47:01PM +0100, Jiri Slaby wrote:
> >> Yeah, I agree this is ugly. Just re-definining MODULE_PARAM_PREFIX at
> >> the end of the file should do the trick (followed by
> >> "module_param(nr_uarts, uint, 0644)").
> > 
> > For some reason, I thought I had tried that.  Maybe I didn't.  I'll look
> > into it again.
> 
> I see. Because we would re-define some global variables. What if we put

Right.  For the peanut gallery, you get this error:

CC      drivers/tty/serial/8250/8250.o
drivers/tty/serial/8250/8250.c:3351:1: error: redefinition of â__check_share_irqsâ
drivers/tty/serial/8250/8250.c:3333:1: note: previous definition of â__check_share_irqsâ was here
drivers/tty/serial/8250/8250.c:3351:1: error: redefinition of â__param_perm_check_share_irqsâ
drivers/tty/serial/8250/8250.c:3333:1: note: previous definition of â__param_perm_check_share_irqsâ was here
drivers/tty/serial/8250/8250.c:3351:1: error: redefinition of â__param_str_share_irqsâ
drivers/tty/serial/8250/8250.c:3333:1: note: previous definition of â__param_str_share_irqsâ was here
drivers/tty/serial/8250/8250.c:3351:1: error: redefinition of â__param_share_irqsâ
drivers/tty/serial/8250/8250.c:3333:1: note: previous definition of â__param_share_irqsâ was here

for each variable you redefine like that.

> module_param into a function?

Not sure what you mean by that.

josh
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/