Re: [PATCH v2 2/3] drivers: android: binder: Fix code style

[mirsal]

On Mon, 2013-03-11 at 16:57 -0700, Arve HjÃnnevÃg wrote:
> On Mon, Mar 11, 2013 at 4:26 PM, Mirsal Ennaime <mirsal@xxxxxxxxx> wrote:
> >  * Use tabs
> >  * Remove a few "80-columns" checkpatch warnings
> >  * Separate code paths with empty lines for readability
> >
> > Signed-off-by: Mirsal Ennaime <mirsal@xxxxxxxxx>
> > ---
> >  drivers/staging/android/binder.c |   42 +++++++++++++++++++++++++-------------
> >  1 file changed, 28 insertions(+), 14 deletions(-)
> >
> > diff --git a/drivers/staging/android/binder.c b/drivers/staging/android/binder.c
> > index 43f823d..4652cd8 100644
> > --- a/drivers/staging/android/binder.c
> > +++ b/drivers/staging/android/binder.c
> > @@ -2927,57 +2927,69 @@ static void binder_deferred_release(struct binder_proc *proc)
> >  {
> >         struct binder_transaction *t;
> >         struct rb_node *n;
> > -       int threads, nodes, incoming_refs, outgoing_refs, buffers, active_transactions, page_count;
> > +       int threads, nodes, incoming_refs, outgoing_refs, buffers,
> > +               active_transactions, page_count;
> >
> >         BUG_ON(proc->vma);
> >         BUG_ON(proc->files);
> >
> >         hlist_del(&proc->proc_node);
> > +
> >         if (binder_context_mgr_node && binder_context_mgr_node->proc == proc) {
> >                 binder_debug(BINDER_DEBUG_DEAD_BINDER,
> > -                            "binder_release: %d context_mgr_node gone\n",
> > -                            proc->pid);
> > +                       "binder_release: %d context_mgr_node gone\n",
> > +                       proc->pid);
> 
> I don't like this change (and the others like it). If is not uncommon
> the align arguments on that don't fit the first line with the
> arguments on the first line, so why change it here?

I actually took the "no tabs for indentation" rule a bit too literally.

Fixed in v3, thank you!

-- 
mirsal

Attachment: signature.asc
Description: This is a digitally signed message part