Re: [PATCH] usb: gadget: remove MACH_OMAP_H4_OTG

[Felipe Balbi]

On Mon, Mar 11, 2013 at 09:14:41PM +0100, Paul Bolle wrote:
> The Kconfig option MACH_OMAP_H4_OTG was already considered dead as of
> v2.6.36, as can be seen in commit
> 267ecec95f7d215d2da38252640b06198515acc3 ("Removing dead
> MACH_OMAP_H4_OTG"). Remove its last trace now.
> 
> Signed-off-by: Paul Bolle <pebolle@xxxxxxxxxx>
> ---
> 0) Tested with "make ARCH=arm menuconfig" (specifically whether setting
> either MACH_OMAP_H2 or MACH_OMAP_H3 still selected ISP1301_OMAP).
> 
> 1) By the way "if ARCH_OMAP" on the next line seems superfluous, as
> ARCH_OMAP1 already selects ARCH_OMAP. Minor nit, actually.
> 
>  drivers/usb/gadget/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/gadget/Kconfig b/drivers/usb/gadget/Kconfig
> index 5a0c541..c65b5e2 100644
> --- a/drivers/usb/gadget/Kconfig
> +++ b/drivers/usb/gadget/Kconfig
> @@ -194,7 +194,7 @@ config USB_FUSB300
>  config USB_OMAP
>  	tristate "OMAP USB Device Controller"
>  	depends on ARCH_OMAP1
> -	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3 || MACH_OMAP_H4_OTG
> +	select ISP1301_OMAP if MACH_OMAP_H2 || MACH_OMAP_H3

could you, instead, just remove the entire line ? we have an overuse of
select and this is one of those cases where it doesn't make sense.

-- 
balbi

Attachment: signature.asc
Description: Digital signature