* PGP Signed by an unknown keypalams read/write api uses the regmap only and hence not break anything on abstraction.
Hi,
On Tue, Mar 26, 2013 at 09:01:42AM +0000, Graeme Gregory wrote:I guess regmap would also help abstracting SPI versus I2C connection.Because I was not a fan of tightly coupling the child devices to theextcon framework uses notification mechanism and Felipe dint likeFrom: Graeme Gregory <gg@xxxxxxxxxxxxxxx>I think this driver is more over the cable connection like vbus
This is the driver for the OTG transceiver built into the Palmas
chip. It
handles the various USB OTG events that can be generated by cable
insertion/removal.
Signed-off-by: Graeme Gregory <gg@xxxxxxxxxxxxxxx>
Signed-off-by: Moiz Sonasath <m-sonasath@xxxxxx>
Signed-off-by: Ruchika Kharwar <ruchika@xxxxxx>
Signed-off-by: Kishon Vijay Abraham I <kishon@xxxxxx>
Signed-off-by: Sebastien Guiriec <s-guiriec@xxxxxx>
---
detetcion or ID pin detection.
Then why not it is implemented based on extcon framework?
using notification here. right Felipe?
That way, generic usb driver (like tegra_usb driver) will getGraeme,
notification through extcon.
We need this cable detection through extcon on our tegra solution
through the Palmas.
+#include <linux/of.h>
+#include <linux/of_platform.h>
+
+static int palmas_usb_read(struct palmas *palmas, unsigned int reg,
+ unsigned int *dest)
+{
+ unsigned int addr;
+ int slave;
+
+ slave = PALMAS_BASE_TO_SLAVE(PALMAS_USB_OTG_BASE);
+ addr = PALMAS_BASE_TO_REG(PALMAS_USB_OTG_BASE, reg);
+
+ return regmap_read(palmas->regmap[slave], addr, dest);
Please use the generic api for palmas_read()/palmas_write(0 as it will
be ease on debugging on register access.
Direct regmap_read() does not help much on this.
Any reason why you dint use palmas_read()/palmas_write here?
Btw palmas_read()/palmas_write() internally uses regmap APIs.
parent MFD. palmas_read/write were added by Laxman.
IMHO, palmas_read/write should be removed.
Laxman's complaint that it doesn't help with debugging is utter
nonsense.