Re: [PATCH v3] watchdog: Add Broadcom BCM2835 watchdog timer driver
From: Lubomir Rintel
Date: Wed Mar 27 2013 - 12:39:47 EST
On Tue, 2013-03-26 at 14:03 -0700, Guenter Roeck wrote:
> On Tue, Mar 26, 2013 at 06:50:00PM +0100, Lubomir Rintel wrote:
> > This adds a driver for watchdog timer hardware present on Broadcom BCM2835 SoC,
> > used in Raspberry Pi and Roku 2 devices.
...
> > +static unsigned int heartbeat = 0;
>
> checkpatch.pl says:
>
> ERROR: do not initialise statics to 0 or NULL
> #178: FILE: drivers/watchdog/bcm2835_wdt.c:44:
> +static unsigned int heartbeat = 0;
Whoops. Will remove.
> > + dev_info(dev, "Broadcom BCM2835 watchdog timer");
> > +
> Hmm .. that means you'll get the info message even in the error case.
> Is that intentional ? It is inconsistent with the remap error message
> above, which does not result in the info message.
That was unintentional -- will change that.
> > + platform_set_drvdata(pdev, NULL);
>
> Still unnecessary.
Oops -- I'll actually remove it this time.
--
Lubomir Rintel <lkundrak@xxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/