Re: [PATCH] clocksource: Fix build in non-OF case
From: Mark Brown
Date: Thu Mar 28 2013 - 09:10:53 EST
On Thu, Mar 28, 2013 at 01:08:22PM +0000, Arnd Bergmann wrote:
> On Thursday 28 March 2013, Mark Brown wrote:
> > That still looks like it'll reference the function?
> Yes, that is intentional. The idea is to create a reference to the
> function so gcc doesn't complain about unused symbols if the function
> gets marked static, but at the same time mark the data structure we
> define as unused so gcc can drop the structure as well as the function
> if they are not referenced from anywhere else. This should let us
> get away with fewer #ifdef hacks in the code, better build-time coverage
> but without producing larger object code.
So GCC is supposed to be smart enough to figure this out and users need
to not do the ifdefs? I have to say this does seem a bit surprising
from a user point of view but it does make sense from a general niceness
point of view.
Attachment:
signature.asc
Description: Digital signature