Re: [PATCH 1/5 v2] USB: regroup all depends on USB within an if USBblock

[Alan Stern]

On Tue, 2 Apr 2013, Florian Fainelli wrote:

> This patch removes the depends on USB from all config symbols in
> drivers/usb/host/Kconfig and replace that with an if USB / endif block
> as suggested by Alan Stern. Some source ... Kconfig lines have been
> shuffled around to permit a better regroupment of the Kconfig files
> depending on "config USB" item. No functionnal change is introduced.

This looks almost right.  The only problem I see is in 
drivers/usb/core/Kconfig.  The USB_OTG_WHITELIST and 
USB_OTG_BLACKLIST_HUB symbols don't have to depend on USB or USB_OTG, 
because they can be set if EXPERT is enabled.

To avoid these issues, I think the best approach is to move all the
USB_OTG* entries over to drivers/usb/otg/Kconfig, where by rights they
should have been all along.

Felipe, do you agree?

Alan Stern

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/