Re: [PATCH 2/2] hfsplus: add printk to log allocation failure inhfs_find_init()

[Vyacheslav Dubeyko]

On Sun, 2013-04-07 at 15:00 -0700, Joe Perches wrote:
> On Mon, 2013-04-08 at 01:21 +0400, Alexey Khoroshilov wrote:
> > Add printk to log allocation failure in hfs_find_init(),
> > "so that there is a sign in dmesg when the error condition is triggered".
> > (per Hin-Tak Leung request)
> 
> Not needed.  There already is a generic dump_stack
> on all allocation failures without __GFP_NOWARN.
> 

I agree too.

Moreover, Hin-Tak asks about dprint() but not printk(). The dprint()
messages can be useful for debugging purposes and will be disabled for
usual kernel build.

I think that adding dprint() messages in hfs_find_init() is not
necessary. But adding dprint() for __hfsplus_ext_write_extent() and
other places can be useful, from my point of view. And such messages can
be useful as for HFS+ as for HFS drivers.

With the best regards,
Vyacheslav Dubeyko.

> > diff --git a/fs/hfsplus/bfind.c b/fs/hfsplus/bfind.c
> []
> > @@ -18,8 +18,10 @@ int hfs_find_init(struct hfs_btree *tree, struct hfs_find_data *fd)
> 
> > +	if (!ptr) {
> > +		printk(KERN_ERR "hfs: allocation failed in hfs_find_init()\n");
> >  		return -ENOMEM;
> 
> 
> --
> To unsubscribe from this list: send the line "unsubscribe linux-fsdevel" in
> the body of a message to majordomo@xxxxxxxxxxxxxxx
> More majordomo info at  http://vger.kernel.org/majordomo-info.html


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/