Re: [PATCH 0/8] Android Binder IPC Fixes

[Serban Constantinescu]

On 06/04/13 00:38, Arve Hjønnevåg wrote:
> On Fri, Apr 5, 2013 at 3:00 PM, Greg KH <gregkh@xxxxxxxxxxxxxxxxxxx> wrote:
> > On Thu, Apr 04, 2013 at 01:32:30PM +0100, Serban Constantinescu wrote:
> > > Hi all,
> > >
> > > This set of patches will clean-up and fix some of the issues that arise
> > > with the current binder interface when moving to a 64bit kernel. All these
> > > changes will not affect the existing 32bit Android interface and are meant
> > > to stand as the base for the 64bit binder compat layer.
> > >
> > > This patch set has been successfully tested on 32bit platforms(ARMv7 VExpress)
> > > and 64bit platforms(ARMv8 RTSM) running a 32bit Android userspace and an in
> > > kernel binder compat layer.
> >
> > I need some acks from some of the Android developers before I can take
> > this.
>
> I still think it is better to change user-space to use 64 bit pointer
> types when running on a 64 bit kernel. These changes do not seem to
> allow 64 bit user-space processes on a 64 bit kernel.

This patch set is independent of whether the binder compat layer lives 
in the kernel or in the userspace. However we need these changes so that 
the same kernel driver supports calls from 32bit userspace and calls 
from 64bit userspace(from the binder kernel driver perspective same as 
64bit kernel/32bit userspace with the compat layer expanding pointers 
and structures to 64bit in the userspace).

We have tested 64/64 functionality using a 64bit Linux filesystem and 
64bit binder unit tests. All tests passed for both kernel/filesystem 
configurations supported by this patch set - 32/32 and 64/64.

Thanks for your feedback,
Serban

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/